Improve LazyProject initialization performance #8955
+175
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
planning to merge this soon now that the release is done. But will take another good look through it first. |
added fast paths to hot methods and all property change listeners which are active during the "opening projects" phase avoid calling findFileObject() or using the lookup in event handlers if possible NewFile (action): remove PropertyChangeListener since the refresh() method isn't doing much anymore beside locking. speeds up post-launch "opening projects" phase by up to 30% when big project groups are loaded
mbien
force-pushed
the
open-projects-performance
branch
from
6e41a88 to
e458f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fast paths to hot methods and all property change listeners which are active during the "opening projects" phase.
Avoid calling
findFileObject()or using theLookupin event handlers if possible.NewFile (action): remove
PropertyChangeListenersince therefresh()which was called from the handler method isn't doing much anymore beside locking.(The event handlers were called almost 1.5m times during the second project group which is why fast paths make such a difference there)
results:
speeds up post-launch "opening projects" phase by up to 30% when big project groups are loaded without making the code more complex (I tried also other tricks but they weren't worth their complexity).
loadInBackground()timings:for 40 maven projects:
for 850 NetBeans ant projects:
no flame graphs this time since I overwrote the baseline graph by accident